myron/novacpx
1
0
Fork 0
mirror of https://github.com/myronblair/novacpx synced 2026-06-30 17:50:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix uninstall not resetting to setup screen

Browse Source 
- proxy.php: always set proxy_mode=disabled and clear remote_host/backend_ip
  on any uninstall, not just when nginx binary is removed
- admin.js: show setup cards when mode==='disabled' regardless of whether
  nginx binary still exists on the remote VM
- Status card shows 'Disabled' instead of 'Stopped' when mode is disabled

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Myron Blair
2026-06-09 13:16:50 +00:00
parent 667f3b3a3c
commit 9bd78a81ea
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
panel/api/endpoints/proxy.php
+3 -4
View File
@@ -200,10 +200,9 @@ try {
$action === 'uninstall' && $method === 'DELETE' => (function() use ($body) {
$removeNginx = !empty($body['remove_nginx']);
$result = ProxyManager::uninstall($removeNginx);
if ($removeNginx) {
$db = DB::getInstance();
$db->execute("INSERT INTO settings (`key`, value) VALUES ('proxy_mode','disabled') ON DUPLICATE KEY UPDATE value='disabled'");
}
// Always reset to disabled — configs are gone regardless of whether nginx binary was removed
$db = DB::getInstance();
$db->execute("INSERT INTO settings (`key`, value) VALUES ('proxy_mode','disabled'),('proxy_remote_host',''),('proxy_backend_ip','') ON DUPLICATE KEY UPDATE value=VALUES(value)");
Response::json(['success' => true, 'data' => ['result' => $result]]);
})(),
panel/public/assets/js/admin.js
+2 -2
View File
@@ -2630,7 +2630,7 @@ async function nginxProxyPage() {
<div class="stats-grid" style="margin-bottom:1.5rem">
<div class="stat-card">
<div class="stat-label">Nginx Status</div>
<div class="stat-value ${run ? 'stat-green' : 'stat-red'}">${inst ? (run ? 'Running' : 'Stopped') : 'Not Configured'}</div>
<div class="stat-value ${run ? 'stat-green' : 'stat-red'}">${cfg.mode === 'disabled' ? 'Disabled' : (run ? 'Running' : 'Stopped')}</div>
<div class="stat-sub">${s.version || (inst ? 'nginx' : 'configure in Settings')}</div>
</div>
<div class="stat-card">
@@ -2650,7 +2650,7 @@ async function nginxProxyPage() {
</div>
</div>
${!inst ? `
${(!inst || cfg.mode === 'disabled') ? `
<div class="panel" style="padding:2rem">
<div style="display:grid;grid-template-columns:1fr 1fr;gap:1.5rem;max-width:680px;margin:0 auto">
<div style="border:1px solid var(--border);border-radius:8px;padding:1.5rem;text-align:center">