myron/tomsjavajive
1
0
Fork 0
mirror of https://github.com/myronblair/tomsjavajive synced 2026-06-30 17:50:32 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix ambiguous column error on shop page JOIN query

Browse Source 
Prefixed is_active, category, product_type_id, name, description, and ORDER BY columns with table alias p to resolve ambiguity with the product_types JOIN.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Myron Blair
2026-06-14 19:56:47 +00:00
parent e6ca96b75c
commit 5c0927af39
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
shop.php
+11 -5
View File
@@ -33,13 +33,19 @@ if ($search) {
} }
$whereClause = implode(' AND ', $where); $whereClause = implode(' AND ', $where);
// Prefix columns that are ambiguous in the JOIN query
$joinWhereClause = str_replace(
['is_active = 1', 'category =', 'product_type_id =', '(name LIKE', 'description LIKE'],
['p.is_active = 1', 'p.category =', 'p.product_type_id =', '(p.name LIKE', 'p.description LIKE'],
$whereClause
);
// Sort // Sort
$orderBy = match($sort) { $orderBy = match($sort) {
'price_low' => 'COALESCE(sale_price, price) ASC', 'price_low' => 'COALESCE(p.sale_price, p.price) ASC',
'price_high' => 'COALESCE(sale_price, price) DESC', 'price_high' => 'COALESCE(p.sale_price, p.price) DESC',
'name' => 'name ASC', 'name' => 'p.name ASC',
default => 'created_at DESC' default => 'p.created_at DESC'
}; };
// Get total count // Get total count
@@ -48,7 +54,7 @@ $pagination = paginate($totalProducts, $page, 12);
// Get products // Get products
$products = db()->fetchAll( $products = db()->fetchAll(
"SELECT p.*, pt.name AS type_name, pt.type_id AS type_slug FROM products p LEFT JOIN product_types pt ON p.product_type_id = pt.type_id WHERE {$whereClause} ORDER BY {$orderBy} LIMIT :limit OFFSET :offset", "SELECT p.*, pt.name AS type_name, pt.type_id AS type_slug FROM products p LEFT JOIN product_types pt ON p.product_type_id = pt.type_id WHERE {$joinWhereClause} ORDER BY {$orderBy} LIMIT :limit OFFSET :offset",
array_merge($params, ['limit' => $pagination['per_page'], 'offset' => $pagination['offset']]) array_merge($params, ['limit' => $pagination['per_page'], 'offset' => $pagination['offset']])
); );