myron/novacpx
1
0
Fork 0
mirror of https://github.com/myronblair/novacpx synced 2026-06-30 17:50:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Security hardening: token-at-rest, rate limiting, XSS, transactions

Browse Source 
- auth: impersonate stores empty data instead of raw cookie; unimpersonate
  issues a fresh session rather than replaying a stored token
- api/index.php: restore rate limiting (10 req/min auth, 120 general)
- nova.js: 401 redirects to login instead of silently returning error;
  escHtml now escapes single quotes to prevent onclick XSS
- accounts: wrap ownership-change 4-write path in beginTransaction/commit;
  restore audit body on account.update
- reseller/user login cards: use $_pname instead of hardcoded 'NovaCPX'

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Myron Blair
2026-06-09 07:51:21 +00:00
parent d29b8b9d65
commit 89c9bfdc49
6 changed files with 69 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
panel/api/endpoints/accounts.php
+8 -1
View File
@@ -97,6 +97,8 @@ match ($action) {
[$id]
);
if (!$acct) Response::error("Account not found", 404);
$db->beginTransaction();
try {
$allowed = ['php_version', 'package_id', 'notes'];
$sets = []; $params = [];
@@ -203,8 +205,13 @@ match ($action) {
}
}
audit('account.update', "account:$id");
$db->commit();
audit('account.update', "account:$id", $body);
Response::success(null, 'Account updated');
} catch (Throwable $e) {
$db->rollBack();
throw $e;
}
})(),
'suspend' => (function() use ($db, $body, $ownerClause) {
panel/api/endpoints/auth.php
+26 -22
View File
@@ -90,9 +90,6 @@ match ($action) {
Response::error('Access denied', 403);
}
// Save caller's current raw session token so we can restore it on unimpersonate
$callerRawToken = $_COOKIE['ncpx_session'] ?? '';
// Create a short-lived impersonation session (2h)
$token = bin2hex(random_bytes(32));
$sessionId = hash('sha256', $token);
@@ -106,7 +103,7 @@ match ($action) {
$_SERVER['REMOTE_ADDR'] ?? '',
$_SERVER['HTTP_USER_AGENT'] ?? '',
$callerId,
json_encode(['return_token' => $callerRawToken]),
json_encode([]),
]
);
@@ -135,30 +132,37 @@ match ($action) {
);
if (!$sess || !$sess['impersonator_id']) Response::error('Not impersonating', 400);
$callerId = (int)$sess['impersonator_id'];
$caller = $db->fetchOne("SELECT role FROM users WHERE id = ?", [$callerId]);
$data = json_decode($sess['data'] ?? '{}', true) ?? [];
$returnToken = $data['return_token'] ?? '';
$callerId = (int)$sess['impersonator_id'];
$caller = $db->fetchOne("SELECT id, role FROM users WHERE id = ?", [$callerId]);
if (!$caller) Response::error('Caller account not found', 404);
// Delete the impersonation session
$db->execute("DELETE FROM sessions WHERE id = ?", [$sessionId]);
// Restore the caller's original session cookie so they land back in their panel logged in
if ($returnToken) {
setcookie('ncpx_session', $returnToken, [
'expires' => time() + 28800,
'path' => '/',
'secure' => true,
'httponly' => true,
'samesite' => 'Strict',
]);
} else {
setcookie('ncpx_session', '', time() - 3600, '/', '', true, true);
}
// Issue a fresh session for the caller — no raw token is ever stored at rest
$newToken = bin2hex(random_bytes(32));
$newSessionId = hash('sha256', $newToken);
$db->execute(
"INSERT INTO sessions (id, user_id, ip_address, user_agent, expires_at, data)
VALUES (?, ?, ?, ?, DATE_ADD(NOW(), INTERVAL 8 HOUR), ?)",
[
$newSessionId,
$callerId,
$_SERVER['REMOTE_ADDR'] ?? '',
$_SERVER['HTTP_USER_AGENT'] ?? '',
json_encode([]),
]
);
setcookie('ncpx_session', $newToken, [
'expires' => time() + 28800,
'path' => '/',
'secure' => true,
'httponly' => true,
'samesite' => 'Strict',
]);
audit('auth.unimpersonate', "returning:{$callerId}");
$role = $caller['role'] ?? 'admin';
Response::success(['portal_url' => Auth::portalUrl($role)], 'Returned to your account');
Response::success(['portal_url' => Auth::portalUrl($caller['role'])], 'Returned to your account');
})(),
'change-password' => (function() use ($body) {