myron/novacpx
1
0
Fork 0
mirror of https://github.com/myronblair/novacpx synced 2026-06-30 17:50:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: docker image-remove throws on daemon error; add sync-orphans endpoint

Browse Source 
- removeImage now throws RuntimeException when docker rmi output contains
  'Error' or 'conflict' so the API returns success:false with the message
- Added docker/sync-orphans endpoint (admin only) to register existing
  Docker containers not tracked in the NovaCPX DB (e.g. after a restore)
This commit is contained in:
Myron Blair
2026-06-22 12:32:44 +00:00
parent 55f5fc1da9
commit 1c4a06d31e
2 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
panel/lib/DockerManager.php
+5 -1
View File
@@ -190,7 +190,11 @@ SH;
public function removeImage(string $imageId): string {
if (!preg_match('/^[a-zA-Z0-9:._\-\/]+$/', $imageId)) throw new RuntimeException("Invalid image ID");
return trim(shell_exec("sudo docker rmi " . escapeshellarg($imageId) . " 2>&1") ?? '');
$out = trim(shell_exec("sudo docker rmi " . escapeshellarg($imageId) . " 2>&1") ?? '');
if (stripos($out, "Error") !== false || stripos($out, "conflict") !== false) {
throw new \RuntimeException($out);
}
return $out;
}
// ── Volumes & Networks ────────────────────────────────────────────────────