Fix 8 issues from code review

- ha-poller: replace recursive main() retry with while loop (stack overflow fix)
- ha-poller: advance last_push on empty HA response (log spam fix)
- ha-poller: use datetime.now(timezone.utc) instead of deprecated utcnow()
- ping-probe: always call update_status() unconditionally so offline devices register as offline
- agent.php: heartbeat reads status from payload instead of hardcoding 'online'
- phone-probe: delegate JSON building to python3 (bash concatenation injection fix)
- netscan + phone-probe: read registration key from /etc/jarvis-agent/reg-key
- admin/index.php: sync ha_list skipDomains with ha.php (14 missing domains added)
- facts_collector: self-check JARVIS via 127.0.0.1 instead of Cloudflare hairpin

agent/pve1-probes/jarvis-phone-probe.sh

@@ -5,7 +5,11 @@
 
 JARVIS_URL="http://10.48.200.211"
 JARVIS_HOST="jarvis.orbishosting.com"
-REG_KEY="f846a9aaf7ce9a61742c63c87c4186052a71d2a580c65518"
+REG_KEY=$(cat /etc/jarvis-agent/reg-key 2>/dev/null)
+if [ -z "$REG_KEY" ]; then
+    echo "$(date): ERROR: /etc/jarvis-agent/reg-key not found" >&2
+    exit 1
+fi
 FUSION_HOST="134.209.72.226"
 
 # IP|alias|extension(none=skip SIP check)|mac
@@ -21,19 +25,17 @@ PHONES=(
 REG_OUTPUT=$(ssh -o StrictHostKeyChecking=no -o ConnectTimeout=5 -o BatchMode=yes \
   root@$FUSION_HOST "fs_cli -x 'show registrations'" 2>/dev/null || echo "")
 
-DEVICES="["
-FIRST=1
+# Collect results as TSV, delegate JSON building to python3 to avoid injection
+RESULTS=""
 for PHONE in "${PHONES[@]}"; do
   IFS='|' read -r IP ALIAS EXT MAC <<< "$PHONE"
 
-  # Ping probe
   if ping -c 1 -W 2 "$IP" > /dev/null 2>&1; then
     STATUS="online"
   else
     STATUS="offline"
   fi
 
-  # SIP check — skip for external phones (ext=none)
   if [ "$EXT" = "none" ]; then
     SIP="external"
   elif [ -n "$REG_OUTPUT" ] && echo "$REG_OUTPUT" | grep -q "^${EXT},"; then
@@ -42,15 +44,31 @@ for PHONE in "${PHONES[@]}"; do
     SIP="unregistered"
   fi
 
-  [ $FIRST -eq 0 ] && DEVICES+=","
-  DEVICES+="{\"ip\":\"$IP\",\"alias\":\"$ALIAS\",\"mac\":\"$MAC\",\"vendor\":\"Yealink\",\"status\":\"$STATUS\",\"sip_status\":\"$SIP\",\"extension\":\"$EXT\"}"
-  FIRST=0
+  RESULTS="${RESULTS}${IP}\t${ALIAS}\t${MAC}\t${STATUS}\t${SIP}\t${EXT}\n"
 done
-DEVICES+="]"
+
+JSON=$(printf "%b" "$RESULTS" | python3 -c "
+import sys, json
+devices = []
+for line in sys.stdin:
+    line = line.rstrip('\n')
+    if not line:
+        continue
+    parts = line.split('\t')
+    if len(parts) < 6:
+        continue
+    ip, alias, mac, status, sip, ext = parts[:6]
+    devices.append({
+        'ip': ip, 'alias': alias, 'mac': mac,
+        'vendor': 'Yealink', 'status': status,
+        'sip_status': sip, 'extension': ext,
+    })
+print(json.dumps({'devices': devices}))
+")
 
 curl -sk --max-time 10 \
   -X POST "$JARVIS_URL/api/netscan" \
   -H "Host: $JARVIS_HOST" \
   -H "Content-Type: application/json" \
   -H "X-Registration-Key: $REG_KEY" \
-  -d "{\"devices\":$DEVICES}" > /dev/null 2>&1
+  -d "$JSON" > /dev/null 2>&1